[X86][GlobalIsel] add strictfp attribute from ir into mir #136702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahesh-attarde
changed the title
phoebewang
reviewed
Apr 22, 2025
| @@ -630,6 +630,10 @@ uint32_t MachineInstr::copyFlagsFromInstruction(const Instruction &I) { | |||
| if (I.getMetadata(LLVMContext::MD_unpredictable)) | |||
| MIFlags |= MachineInstr::MIFlag::Unpredictable; | |||
|
|
|||
| if (const CallInst *CI = dyn_cast<CallInst>(&I)) { | |||
| MIFlags |= | |||
| CI->hasFnAttr(llvm::Attribute::StrictFP) ? MachineInstr::NoFPExcept : 0; | |||
There was a problem hiding this comment.
NoFPExcept is to clear the flag, not to set it.
There was a problem hiding this comment.
Let me recheck my use case again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am supporting
G_IS_FPCLASSopcode and noticedstrictfpattribute was not forwarded into MIFlag.This patch adds attribute to MIR in GISEL-IRTranslator.
Requirement comes from
G_IS_FPCLASSPR mahesh-attarde#4 for strictfp.